fix: update version landing pages with new i18n references#773
Open
mcdurdin wants to merge 1 commit into
Open
Conversation
* Update the call to `downloadSection()` in version landing pages to match the new identifiers used in ui/downloads.php. Fixes the base issue for the versioned landing pages. * Refactor `Locale::definePageScope` to declare standard `$_m_<domain>` variable and `_m_<domain>()` function, so that we can skip the Locale initialization boilerplate in more places. Also make it possible to declare multiple scopes (supporting includes in the future), and make the function idempotent. * Update references to `[$]_m*` to the common pattern provided in `Locale::definePageScope`. * Add version landing pages to _test/ so that they are crawled in the link checker. Fixes: #764 Fixes: KEYMAN-COM-3H1 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the call to
downloadSection()in version landing pages to match the new identifiers used in ui/downloads.php. Fixes the base issue for the versioned landing pages.Refactor
Locale::definePageScopeto declare standard$_m_<domain>variable and_m_<domain>()function, so that we can skip the Locale initialization boilerplate in more places. Also make it possible to declare multiple scopes (supporting includes in the future), and make the function idempotent.Update references to
[$]_m*to the common pattern provided inLocale::definePageScope.Add version landing pages to _test/ so that they are crawled in the link checker.
Fixes: #764
Fixes: KEYMAN-COM-3H1
Test-bot: skip