fix(windows): fix download failing when cache.json missing 🍒 🏠#14207
Merged
rc-swag merged 10 commits intostable-18.0from Jun 24, 2025
Merged
fix(windows): fix download failing when cache.json missing 🍒 🏠#14207rc-swag merged 10 commits intostable-18.0from
rc-swag merged 10 commits intostable-18.0from
Conversation
or stale. This commit adds a precondition check when entering the Download state. It checks to see if the cache.json file still exists then it checks if there are packages or installer files to download. This will also check the version with ucrsUpdateReady, so if the installed version is already newer it will not attempt the download. If the check fails it will removed any cached files and return to the idle state and check for updates. Fixes: #13767
When determining whether to move to the update available the ucrsUpdateReady is now taken into account, not just the wucSuccess flag. All the cases that check if there is Keyman installer file in the metadata now check for this, and this was the original intent. A two new function HasKeymanInstallFileUpdate and CheckMetaDataForUpdate have been added to aid this check.
is invalid or the version is not newer then currently installed
User Test ResultsTest specification and instructions User tests are not required |
TRemoteUpdateCheckResult now has wucUpdateAvailable and wucNotChecked to avoid confusion
There will be no `firstrun` for kmshell.exe if it is a keyboard only install. We can therefore return to the idle state in the current process
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
keymanapp-test-bot
bot
changed the title
Member
|
process nits:
|
mcdurdin
added
windows/
cherry-pick
mcdurdin
changed the title
ermshiperete
approved these changes
Jun 23, 2025
…wuc-enum-result fix(windows): add values wucUpdateAvailable and wucNotChecked to TRemoteUpdateCheckResult enum 🍒 🏠
rc-swag
deleted the
fix/windows/cherry-pick/not-downloaded-after-3-attempts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13767
Cherry-pick-of: #14095
Cherry-pick-of: #14166
Test-bot: skip