Skip to content

maint(windows): replace Powershell scripts 🪶#14256

Merged
ermshiperete merged 3 commits intomaint/windows/13399_tconfigfrom
maint/windows/rsync
Jul 3, 2025
Merged

maint(windows): replace Powershell scripts 🪶#14256
ermshiperete merged 3 commits intomaint/windows/13399_tconfigfrom
maint/windows/rsync

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

@ermshiperete ermshiperete commented Jul 2, 2025

Refactors the Powershell scripts that download and upload files and create .download_info files.

This change is based on #14236/#14254 which bypasses the path rewriting that msys does when calling Windows rsync. Part of this change was done for developer in #14255.

Related: #14236, #14255
Build-bot: skip
Test-bot: skip

Build-bot: skip
Test-bot: skip
@ermshiperete ermshiperete requested a review from mcdurdin July 2, 2025 15:02
@github-project-automation github-project-automation bot moved this to Todo in Keyman Jul 2, 2025
@github-actions github-actions bot added web/ windows/ android/ developer/ ios/ mac/ linux/ common/ core/ Keyman Core resources/ maint Maintenance work -- continuous integration, build scripts, infrastructure labels Jul 2, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jul 2, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Jul 2, 2025

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S6 milestone Jul 2, 2025
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Jul 2, 2025
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick of #14254 so that I can make use of the new functions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick of #14254 so that I can make use of the new functions.

Refactors the Powershell scripts that download and upload files and
create .download_info files.

This change is based on #14236/#14254 which bypasses the path rewriting
that msys does when calling Windows rsync. Part of this change was done
for developer in #14255.

Related: #14236, #14255
@ermshiperete ermshiperete force-pushed the maint/windows/rsync branch from 1b6a85e to 8bb0be2 Compare July 2, 2025 16:44
@ermshiperete ermshiperete changed the title maint(windows): replace Powershell scripts maint(windows): replace Powershell scripts 🪶 Jul 2, 2025
Co-authored-by: Marc Durdin <marc@durdin.net>
@ermshiperete ermshiperete merged commit 8cff297 into maint/windows/13399_tconfig Jul 3, 2025
4 of 5 checks passed
@ermshiperete ermshiperete deleted the maint/windows/rsync branch July 3, 2025 10:43
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android/ common/ core/ Keyman Core developer/ ios/ linux/ mac/ maint Maintenance work -- continuous integration, build scripts, infrastructure resources/ web/ windows/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants