maint(linux): use tc_rsync_upload and write_download_info functions 🪶#14258
Merged
ermshiperete merged 1 commit intomasterfrom Jul 3, 2025
Merged
maint(linux): use tc_rsync_upload and write_download_info functions 🪶#14258ermshiperete merged 1 commit intomasterfrom
tc_rsync_upload and write_download_info functions 🪶#14258ermshiperete merged 1 commit intomasterfrom
Conversation
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
web/
windows/
android/
developer/
ios/
mac/
linux/
common/
core/
keymanapp-test-bot
bot
removed
the
user-test-missing
ermshiperete
changed the title
tc_rsync_upload and write_download_info functionstc_rsync_upload and write_download_info functions 🪶
Also make `_tc_rsync` function cross-platform. A comparison might show that we omit `--perms` when calling rsync with this change. However the short form (`-p`) is already included, so we don't have to additional add the long form `--perms`.
ermshiperete
force-pushed
the
maint/linux/rsync
branch
from
f8c6ded to
e82a873
Compare
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.76-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also make
_tc_rsyncfunction cross-platform.A comparison might show that we omit
--permswhen calling rsync with this change. However the short form (-p) is already included, so we don't have to additional add the long form--perms.Test-bot: skip