maint(android): remove --ci parameter from android builds#14264
Merged
maint(android): remove --ci parameter from android builds#14264
--ci parameter from android builds#14264Conversation
`--ci` is deprecated since the current code discovers automatically when we're building on CI, so we don't have to pass that option when calling the `android/build.sh` script. Also remove the option itself since we're no longer using it. Build-bot: build android Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
github-actions
bot
added
android/
resources/
maint
darcywong00
requested changes
Jul 3, 2025
Contributor
darcywong00
left a comment
darcywong00
left a comment
There was a problem hiding this comment.
I think we intentionally had to leave the --ci parameter in (to remove in 20.0) because the stable-18.0 build still requires it.
See #13772 (comment)
mcdurdin
approved these changes
Jul 3, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM
@darcywong00 the option remains in 18.0 and in the 18.0-specific build configuration steps in TeamCity, but can be removed here as this is all 19.0-only.
Contributor
|
ah. So the build configuration steps have since been split for 19.0 and 18.0. gotcha |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.77-alpha |
ermshiperete
added a commit
that referenced
this pull request
Jul 9, 2025
remove it for release builds. This PR fixes this. Follow-up-of: #14264 Build-bot: skip Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--ciis deprecated since the current code discovers automatically when we're building on CI, so we don't have to pass that option when calling theandroid/build.shscript.Also remove the option itself since we're no longer using it.
Build-bot: build android
Test-bot: skip