refactor(common): some reformattings in shellHelperFunctions.sh 🐉#14269
refactor(common): some reformattings in shellHelperFunctions.sh 🐉#14269ermshiperete merged 1 commit intomasterfrom
shellHelperFunctions.sh 🐉#14269Conversation
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
changed the title
shellHelperFunctions.shshellHelperFunctions.sh 🐉
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM. I want to cleanup the unused functions in shellHelperFunctions.sh and eventually remove the whole file, moving remaining functions into other files -- it was specific to iOS builds for a long time and I think many of the functions are now unused. The function names are also far too generic (set_version?) and liable to cause name collisions.
|
I think we should be running builds on this -- changes to shared shell scripts should always be built, even if they seem inconsequential |
|
https://github.com/keymanapp/keyman/actions/runs/16061128742/job/45327107509 |
Also always include `jq.inc.sh`. The include file already has everything we did here. Test-bot: skip
ermshiperete
force-pushed
the
refactoring/common/shellHelperFuncs
branch
from
5f86f42 to
38f43d8
Compare
ermshiperete
changed the base branch from
maint/resources/14201_prefixtc
to
master
|
Changes in this pull request will be available for download in Keyman version 19.0.79-alpha |
Adds documentation for various functions, removes unused functions (a couple of simple, very lightly used functions were unDRYed; these could go back the other way across all shell scripts if necessary). TODO items noted for follow-up refactoring. Fixes: #14275 Relates-to: #14269 Build-bot: build all Test-bot: skip
3 participants
Also always include
jq.inc.sh. The include file already has everything we did here.Build-bot: build
Test-bot: skip