fix(windows): check if automatic updates off before prompt#14295
Merged
fix(windows): check if automatic updates off before prompt#14295
Conversation
Before prompting check if automatic updates has been turned off in the time sitting in waiting for restart. Also check it as we transition to waiting for restart in case it was turned off while downloading. Fixes:#14262
User Test ResultsTest specification and instructions
Test Artifacts |
If it has been determined the user turned off automatic updates in the function ShouldSendToBUpdateSM then it shall return early.
Contributor
Author
User TestingTEST_UPDATE_CANCELED_NO_PROMPTInstall the Keyman for Windows Build associated with this PR.
TEST_UPDATE_PROMPTThis is a regression to test to ensure the "normal" case still works.
|
mcdurdin
approved these changes
Aug 18, 2025
windows/src/desktop/kmshell/main/Keyman.System.UpdateStateMachine.pas
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <marc@durdin.net>
Contributor
Test ResultsBefore testing:
|
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.106-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before prompting check if automatic updates has been turned off in the time sitting in waiting for restart.
Also check it as we transition to waiting for restart in case it was turned off while downloading.
Build-bot: release windows
Fixes: #14262