Skip to content

maint(android): fix Android release build#14329

Merged
ermshiperete merged 1 commit intomasterfrom
maint/android/fixrelease
Jul 10, 2025
Merged

maint(android): fix Android release build#14329
ermshiperete merged 1 commit intomasterfrom
maint/android/fixrelease

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

Uses absolute paths for zipping files.

Follow-up-of: #14308
Build-bot: skip
Test-bot: skip

Uses absolute paths for zipping files.

Follow-up-of: #14308
Build-bot: skip
Test-bot: skip
@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S7 milestone Jul 10, 2025
@github-actions github-actions bot added the maint Maintenance work -- continuous integration, build scripts, infrastructure label Jul 10, 2025
@ermshiperete ermshiperete merged commit 195bf68 into master Jul 10, 2025
7 checks passed
@ermshiperete ermshiperete deleted the maint/android/fixrelease branch July 10, 2025 14:59
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Jul 10, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.82-alpha

@mcdurdin
Copy link
Copy Markdown
Member

Questions:

  • What does this fix?
  • Have you verified the new .zip file still has the correct folder layout?

@darcywong00
Copy link
Copy Markdown
Contributor

Questions:

  • What does this fix?
  • Have you verified the new .zip file still has the correct folder layout?

Ah, maybe this PR is more about using absolute paths for creating the Keyman Engine for Android artifact.

I compared the file structures between 19.0.80 and 19.0.83 and it's still got the correct folder layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android/ maint Maintenance work -- continuous integration, build scripts, infrastructure resources/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants