maint(linux): fix locate_emscripten if $EMSCRIPTEN_BASE dir missing 🐘#14347
Merged
ermshiperete merged 1 commit intomasterfrom Jul 23, 2025
Merged
maint(linux): fix locate_emscripten if $EMSCRIPTEN_BASE dir missing 🐘#14347ermshiperete merged 1 commit intomasterfrom
locate_emscripten if $EMSCRIPTEN_BASE dir missing 🐘#14347ermshiperete merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
resources/
linux/
maint
ermshiperete
changed the title
locate_emscripten if $EMSCRIPTEN_BASE dir missinglocate_emscripten if $EMSCRIPTEN_BASE dir missing 🐘
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
If the `$EMSCRIPTEN_BASE` dir is missing (which usually points to `emsdk/upstream/emscripten`), but we have the `emsdk` root directory with `emsdk/emsdk`, we can have everything we need to install the desired emscripten version. Issue #13464 describes an error where the `upstream/emscripten` directory was missing - probably because the build got interrupted while installing emscripten. This change fixes this. Fixes: #13464 Test-bot: skip
ermshiperete
force-pushed
the
maint/linux/13464_emscripten
branch
from
a7a2788 to
e634f20
Compare
mcdurdin
approved these changes
Jul 22, 2025
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.88-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
$EMSCRIPTEN_BASEdir is missing (which usually points toemsdk/upstream/emscripten), but we have theemsdkroot directory withemsdk/emsdk, we can have everything we need to install the desired emscripten version.Issue #13464 describes an error where the
upstream/emscriptendirectory was missing - probably because the build got interrupted while installing emscripten. This change fixes this.Fixes: #13464
Test-bot: skip