maint(common): set C++17 in standard.meson.build 🐾#14355
Merged
ermshiperete merged 1 commit intomasterfrom Jul 21, 2025
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
mac/
core/
srl295
approved these changes
Jul 14, 2025
github-actions
bot
added
developer/
developer/compilers/
common/
and removed
common/
labels
ermshiperete
force-pushed
the
maint/common/12526_c++17
branch
from
5f578ed to
17fd782
Compare
ermshiperete
changed the title
ermshiperete
force-pushed
the
maint/common/12526_c++17
branch
from
17fd782 to
c7dee59
Compare
ermshiperete
force-pushed
the
refactor/developer/codecvt
branch
from
d9843e0 to
6930fe9
Compare
Note that the ICU subprojects still explicitly specify C++17 since they are maintained outside of Keyman and so shouldn't be tied to the Keyman compiler version requirement. Fixes: #12526 Test-bot: skip
ermshiperete
force-pushed
the
maint/common/12526_c++17
branch
from
c7dee59 to
faa521d
Compare
github-actions
bot
added
common/
developer/
developer/compilers/
and removed
developer/
common/
developer/compilers/
labels
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.86-alpha |
mcdurdin
added a commit
that referenced
this pull request
Aug 1, 2025
We attempted to set the C++ version in standard.meson.build, but this does not work well as the option name varies by platform, and it also triggers a warning in meson. This fix moves the setting into each meson.build project() default_options. As there are only a handful of these, the maintenance burden is not high. Fixes: #14432 Relates-to: #14355 Build-bot: build Test-bot: skip
cvosoft
pushed a commit
to cvosoft/keyman
that referenced
this pull request
Oct 23, 2025
We attempted to set the C++ version in standard.meson.build, but this does not work well as the option name varies by platform, and it also triggers a warning in meson. This fix moves the setting into each meson.build project() default_options. As there are only a handful of these, the maintenance burden is not high. Fixes: keymanapp#14432 Relates-to: keymanapp#14355 Build-bot: build Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the ICU subprojects still explicitly specify C++17 since they are maintained outside of Keyman and so shouldn't be tied to the Keyman compiler version requirement.
Fixes: #12526
Test-bot: skip