maint(common): fix use of jq.inc.sh in git hooks#14382
Merged
ermshiperete merged 1 commit intomasterfrom Jul 22, 2025
Merged
Conversation
`jq.inc.sh` gets also used in some scripts that don't source our builder scripts, e.g. in git hooks. This means that `builder_is_windows` is not defined. This change replaces the call of that function with a slightly modified version of the previous implementation. Follow-up-of: #14324 Build-bot: skip Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
resources/
common/
maint
mcdurdin
approved these changes
Jul 21, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM. Are there changes to other .inc.sh scripts which have similar non-builder-aware usages?
Contributor
Author
No, |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.87-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jq.inc.shgets also used in some scripts that don't source our builder scripts, e.g. in git hooks. This means thatbuilder_is_windowsis not defined. This change replaces the call of that function with a slightly modified version of the previous implementation.Follow-up-of: #14324
Build-bot: skip
Test-bot: skip