maint(common): fix add_zip_files if flags come before zip filename#14387
maint(common): fix add_zip_files if flags come before zip filename#14387ermshiperete merged 2 commits intomasterfrom
add_zip_files if flags come before zip filename#14387Conversation
Previously `add_zip_files` didn't work if the zip filename was not specified as first parameter. This change allows it to come after flags. This will fix web release builds. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
resources/
common/
maint
| ZIP_FILE="$1" | ||
| else | ||
| INCLUDE+=("$1") | ||
| fi |
There was a problem hiding this comment.
ah, I think this will fix the Android build too.
Can you update the header comments ll. 11-12? (and maybe you took care of the TODO on line 9)
There was a problem hiding this comment.
actually, if the zip filename needs to be after the flags now, I think the android/build.sh will need to get updated too
There was a problem hiding this comment.
... and ios/tools/prepRelease.sh ?
There was a problem hiding this comment.
The flags can come anywhere now. Added unit tests that show that.
Also updated the function header and removed the TODO (saw that yesterday but then forgot to remove...). Thanks!
- update doc in the function header - add unit tests to show that flags are allowed anywhere now
|
Changes in this pull request will be available for download in Keyman version 19.0.87-alpha |
4 participants
Previously
add_zip_filesdidn't work if the zip filename was not specified as first parameter. This change allows it to come after flags.This will fix web release and other builds.
Test-bot: skip