fix(web): use actual legacy model for legacy-model support unit tests#14460
fix(web): use actual legacy model for legacy-model support unit tests#14460
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
Some nits about the PR title/body 😄
|
Thought about deleting, but it is a possible case. Not one we've been made aware of, of course - at this point, it'd only matter if someone out there actually did write and distribute their own custom model. |
I think then that we should delete it. We can always put it back if the need arises. Having skipped tests is just an unnecessary flag in test results otherwise. |
|
Changes in this pull request will be available for download in Keyman version 19.0.95-alpha |
|
Changes in this pull request will be available for download in Keyman version 19.0.95-alpha |
Noticed this during work on epic-autocorrect when the "legacy model" tests failed from intermediate changes that shouldn't - and, in fact, didn't - apply to legacy models.
The
TrieModelis non-legacy - it's very much updated for 14.0+ features. The oldDummyModel, though... that one does not leverage 14.0+ features, thus can test those pathways. Sadly, it doesn't use keying - it just "dummies in" specific suggestions, so the corresponding legacy test (for use of keying) is now skipped.@keymanapp-test-bot skip