maint(resources): build.sh-style commands for build-bot 🦌#14461
maint(resources): build.sh-style commands for build-bot 🦌#14461
Conversation
Legacy format will still work, but preferred format is now `Build-bot: level:platform[,...platform] ...` Fixes: #14419 Build-bot: build Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
docs
resources/
maint
|
|
||
| for i in "${!expected_build_platforms[@]}"; do | ||
| assert-equal "${build_platforms[$i]}" "${expected_build_platforms[$i]}" "PR #$prnum: build_platforms[$i]" | ||
| assert-equal "${build_platforms[$i]:-missing}" "${expected_build_platforms[$i]:-missing}" "PR #$prnum: build_platforms[$i]" |
There was a problem hiding this comment.
Where does -missing coming from?
There was a problem hiding this comment.
This is so the script fails with a legible assertion failure if the $build_platforms array is missing a value at index $i, rather than with an (obscure) script error. I experienced this when I was running tests in developing this. The missing value does not appear on successful runs.
I guess the $expected_build_platorms[$i] should never be missing because this is a loop iterating over that array!
…urces/14419-build-sh-style-build-bot
mcdurdin
changed the title
|
Changes in this pull request will be available for download in Keyman version 19.0.95-alpha |
|
Changes in this pull request will be available for download in Keyman version 19.0.95-alpha |
|
|
||
| ``` | ||
| Build-bot: <BuildLevel> [Platforms] | ||
| Build-bot: <BuildLevel>:[Platforms] ... |
There was a problem hiding this comment.
Should the colon be inside of the square brackets?
| Build-bot: <BuildLevel>:[Platforms] ... | |
| Build-bot: <BuildLevel>[:Platforms] ... |
There was a problem hiding this comment.
Should the colon be inside of the square brackets?
Will fix in #14548
4 participants
Legacy format will still work, but preferred format is now
Build-bot: level:platform[,...platform] ...Fixes: #14419
Build-bot: build
Test-bot: skip