fix(android): Get default sizes before initializing keyboard

[darcywong00]

Fixes #14455 with @chrisvire's code suggestions.

I needed to move the last 4 lines of code above the call to initKeyboard. This seems like a legitimate bug (order of initialization) in KMEA.

This way the keyboard sizes are retrieved from preferences before the inapp and system keyboards are initialized.

I think this contributed to intermittent reports from FirstVoices about a squished keyboard (but couldn't get a repro).
The keyboard harness test app seems to be a good repro, so I will include for user testing

will need to 🍒 pick to stable-18.0

User Testing

Setup - Install the PR builds of Keyman for Android and the KeyboardHarness test apps on the Android device/emulator (I suggest API 34)

• TEST_KEYMAN - Verifies default keyboard heights work

1. Launch Keyman for Android and dismiss the Get Started menu
2. Observe the keyboard heights for both portrait and landscape orientation
3. From Keyman settings --> Adjust keyboard height --> adjust the keyboard height for both portrait and landscape orientation and then exit the menu back to Keyman
4. Verify the keyboard heights match the specified adjusted heights for both portrait and landscape orientation
5. Exit the app and relaunch Keyman for Android
6. Verify the keyboard heights still match the specified adjusted heights for both portrait and landscape orientation
7. Go back to Keyman settings --> Adjust keyboard height --> "Reset to defaults" in both portrait and landscape orientation
8. Exit the app and relaunch Keyman for Android
9. Observe the keyboard heights and verify they match the default heights for both portrait and landscape orientation (from step 2)

• TEST_KEYBOARD_HARNESS - Verifies the OSK is visible

1. Launch the KeyboardHarness test app
2. Verify the keyboard height is not squished

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_KEYMAN (PASSED) (notes)
• ✅ TEST_KEYBOARD_HARNESS (PASSED) (notes)

Test Artifacts

• Android
  • Keyman for Android apk
  • FirstVoices for Android 16.0 apk
  • FirstVoices Keyboards for Android apk
  • KeyboardHarness apk
  • Keyman for Android 16.0 apk
  • KMSample1 apk
  • KMSample2 apk

[dinakaranr]

Test Results

Prerequisites:
I installed this PR build of Android and the keyboard harness test apps on the Android 14, API_34. Here I am sharing my observation.
I tested this PR in the "Keyman-19.0.95-alpha-test-14472" build on Android 14, API_34(Emulator, Samsung A23). Here I am sharing my observation.

• TEST_KEYMAN (Passed):

1. Launch Keyman for Android and dismiss the Get Started menu
2. Observed that the keyboard heights for both portrait and landscape orientation
3. Observed that the keyboard heights by clicking from Keyman settings --> Adjust keyboard height --> adjust the keyboard height for both portrait and landscape orientation.
4. Exit the menu back to Keyman note app.
5. Verified that the keyboard heights match the specified adjusted heights for both portrait and landscape orientation
6. Exit the app from the "Recents"
7. Relaunch Keyman for Android
8. Verified that the keyboard heights still match the specified adjusted heights for both portrait and landscape orientation
9. Launch Keyman for Android and dismiss the Get Started menu
10. Go back to Keyman settings --> Adjust keyboard height --> "Reset to defaults" in both portrait and landscape orientation
11. Exit the app from the "Recents"
12. Relaunch Keyman for Android
13. Observed that the keyboard heights
14. Verified they match the default heights for both portrait and landscape orientation (from step 2)

• TEST_KEYBOARD_HARNESS (Passed):

1. Launch the KeyboardHarness test app
2. Verified that the keyboard height is not squished.
3. Verified that the keyboard appeared without UI issue.

[keyman-server]

Changes in this pull request will be available for download in Keyman version 19.0.95-alpha

[keyman-server]

Changes in this pull request will be available for download in Keyman version 19.0.95-alpha