Skip to content

fix(android): Add FirstVoices preference to show on-screen keyboard 👁️#14546

Merged
darcywong00 merged 1 commit intomasterfrom
fix/android/fv-show-osk
Aug 20, 2025
Merged

fix(android): Add FirstVoices preference to show on-screen keyboard 👁️#14546
darcywong00 merged 1 commit intomasterfrom
fix/android/fv-show-osk

Conversation

@darcywong00
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 commented Aug 19, 2025

Follows #14539 in addressing #14533

This adds a FirstVoices app setting preference to show the on-screen keyboard while using physical keyboard.
Unlike the Keyman app, the FirstVoices app doesn't have an app-level Settings page. So I added the toggle to the "Setup" menu

fv-show-osk

Note to reviewers: the Android Studio IDE changed some whitespace, so you may want to review with ?w=1

User Testing

Setup - Install the PR build of FirstVoices for Android on an Android emulator of API 36.

Configure Gboard to display on-screen keyboard:
device Settings --> Keyboard --> On-screen keyboard --> click Gboard --> Physical keyboard --> Show on-screen keyboard to "on"
back to Gboard settings --> write in text fields --> Use stylus to write in text fields , set to "off"

Configure FirstVoices --> Select keyboards --> Region --> BC Coast --> Sencoten --> Enable keyboard
FirstVoices --> Setup --> enable FirstVoices and enable as the current input method

  • TEST_PREFERENCE_OFF - Verifies FirstVoices OSK doesn't appear by default
  1. Launch FirstVoices
  2. Got to Setup --> verify "Show on-screen keyboard" has a default value off
  3. Launch Chrome and select a text area
  4. Verify the FirstVoices system OSK does not appear
  • TEST_PREFERENCE_ON - Verifies FirstVoices OSK appears when "Show OSK" is on
  1. Launch FirstVoices
  2. Got to Setup --> set "Show on-screen keyboard" to on
  3. Completely close the FirstVoices app
  4. Launch Chrome and select a text area
  5. If the system keyboard is Gboard, longpress the globe button to switch to FirstVoices system keyboard
  6. Verify the FirstVoices system OSK appears
  7. Verify the FirstVoices Sencoten keyboard and suggestion banner functions

@darcywong00 darcywong00 added this to the A19S10 milestone Aug 19, 2025
@github-project-automation github-project-automation bot moved this to Todo in Keyman Aug 19, 2025
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Aug 19, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Aug 19, 2025

@keymanapp-test-bot keymanapp-test-bot bot added the user-test-required User tests have not been completed label Aug 19, 2025
@Nnyny Nnyny self-assigned this Aug 19, 2025
@Nnyny
Copy link
Copy Markdown
Contributor

Nnyny commented Aug 19, 2025

Test Results

Before testing:
- Install firstvoices-19.0.101.apk on API 36
- Go to Settings > System > On-screen keyboard > Gboard is on by default
- Go to Gboard setting > Write in text fields > turn off 'Use stylus to write in text fields'
- Go to FirstVoices > Select keyboards > BC Coast > Sencoten > turn on 'Enabled keyboard'
- Go back to FirstVoices welcome page > Setup> select 'Enabled FirstVoices' and 'Choose Firstvoices as current input method'

  • TEST_PREFERENCE_OFF (PASSED): notes
  1. Go to FirstVoices and verify that 'Show On-Screen Keyboard when physical keyboard is connected' is off
  2. Go to Chrome and select on the text area
  3. Confirm FirstVoices OSK doesn't show up
  • TEST_PREFERENCE_ON (PASSED): notes
  1. Go to FirstVoices and turn on 'Show On-Screen Keyboard when physical keyboard is connected'
  2. Close the app and go to Chrome
  3. Select the text area and confirm that FirstVoices Sencoten keyboard with predictive text shows up
  4. Type the keyboard and dictionary, confirm it's functioning ok

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Aug 19, 2025
Base automatically changed from fix/android/36-hidden to master August 20, 2025 02:34
@darcywong00 darcywong00 merged commit 7343d78 into master Aug 20, 2025
8 checks passed
@darcywong00 darcywong00 deleted the fix/android/fv-show-osk branch August 20, 2025 02:34
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Aug 20, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.103-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants