Skip to content

fix(android): polyfill globalThis for API 28 devices 🍒 🏠#14553

Merged
jahorton merged 3 commits intostable-18.0from
fix/android/cherrypick/globalThis-polyfill
Aug 20, 2025
Merged

fix(android): polyfill globalThis for API 28 devices 🍒 🏠#14553
jahorton merged 3 commits intostable-18.0from
fix/android/cherrypick/globalThis-polyfill

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

Fixes: #14450
Cherry-pick-of: #14541

User Testing

TEST_REPRO_ISSUE: Attempt to repro the original issue and verify that the keyboard is visible.

  • Install on Android device/emulator Android API 28.
  • Observe the keyboard is visible after the app launches.

@github-project-automation github-project-automation bot moved this to Todo in Keyman Aug 19, 2025
@github-actions github-actions bot added android/ android/engine/ cherry-pick Change already merged into another (stable) branch fix stable labels Aug 19, 2025
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Aug 19, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Aug 19, 2025

@keymanapp-test-bot keymanapp-test-bot bot changed the title fix(android): polyfill globalThis for API 28 devices 🍒 fix(android): polyfill globalThis for API 28 devices 🍒 🏠 Aug 19, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S10 milestone Aug 19, 2025
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nnyny Nnyny self-assigned this Aug 20, 2025
@Nnyny
Copy link
Copy Markdown
Contributor

Nnyny commented Aug 20, 2025

Test Results

  • TEST_REPRO_ISSUE (PASSED): notes
  1. Install keyman-18.0.239-test-14553 on API 28
  2. Open Keyman and verify the keyboard and dictionary appear and functioning fine

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Aug 20, 2025
@jahorton jahorton merged commit 65f832d into stable-18.0 Aug 20, 2025
7 checks passed
@jahorton jahorton deleted the fix/android/cherrypick/globalThis-polyfill branch August 20, 2025 13:20
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Aug 20, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android/engine/ android/ cherry-pick Change already merged into another (stable) branch fix has-user-test stable

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants