docs(web): improve documentation for SearchSpace and SearchNode#14555
Merged
docs(web): improve documentation for SearchSpace and SearchNode#14555
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Aug 20, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM, thanks for the additional code docs!
darcywong00
reviewed
Aug 20, 2025
|
|
||
| // While this may SEEM to be unnecessary, note that sometimes substitutions (which are computed | ||
| // via insert + delete) may be lower cost than both just-insert and just-delete. | ||
| /** |
Contributor
There was a problem hiding this comment.
Are the 2 lines above applicable to buildSubstitutionEdges?
Contributor
Author
There was a problem hiding this comment.
They are, but it's more of an internal implementer's note, as to why I wrote the design the way it is all the way back then - that's why they're outside of the doc-comment.
ermshiperete
approved these changes
Aug 20, 2025
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.103-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build-bot: skip
Test-bot: skip