refactor(web): move computeAlignment core to standalone method 🚂 #14573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
darcywong00
approved these changes
Aug 22, 2025
Comment on lines
17
to
22
| export type ContextStateAlignment = { | ||
| /** | ||
| * Denotes whether or not alignment is possible between two contexts. | ||
| */ | ||
| canAlign: false | ||
| } | { |
Contributor
There was a problem hiding this comment.
I see this a lot in the tests. Is it worth making a const?
ermshiperete
approved these changes
Aug 22, 2025
…eb/independent-compute-alignment
…eb/independent-compute-alignment
…eb/independent-compute-alignment
…eb/independent-compute-alignment
Base automatically changed from
fix/web/sliding-tokenization-alignment
to
epic/autocorrect
September 3, 2025 16:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates-to: #14480
This is being done to prepare for a fix to #14480, which is needed to better handle complex input transforms and tokenization scenarios. The easiest way to consistently index the tokenized transforms... is to perform context alignment on the results of transform application.
@keymanapp-test-bot skip