refactor(common): fix shellcheck warnings#14580
Merged
ermshiperete merged 4 commits intomasterfrom Aug 27, 2025
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Aug 22, 2025
| set +o noglob | ||
|
|
||
| if ([[ "$prTestCommand" == skip ]] || [[ -z "${prTestCommand// }" ]]) && [[ -z "${prTestBody// }" ]]; then | ||
| if { [[ "${prTestCommand}" == skip ]] || [[ -z "${prTestCommand// }" ]]; } && [[ -z "${prTestBody// }" ]]; then |
Contributor
There was a problem hiding this comment.
I'm unclear how the curly brace grouping works in an if statement
Contributor
Author
There was a problem hiding this comment.
That was a suggestion from shellcheck (SC2235). Serves the same purpose as the parens, but doesn't create a subshell and so is faster.
Test-bot: skip
ermshiperete
force-pushed
the
refactor/common/shellcheck
branch
from
a1739bd to
4c57967
Compare
Also rename variables to make it clearer that `buildBotCommand` contains multiple commands.
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.106-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-bot: skip