fix(android): Update KMSample1 layout when changing orientation#14678
Merged
darcywong00 merged 1 commit intomasterfrom Sep 4, 2025
Merged
fix(android): Update KMSample1 layout when changing orientation#14678darcywong00 merged 1 commit intomasterfrom
darcywong00 merged 1 commit intomasterfrom
Conversation
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts |
Contributor
Test ResultsBefore testing:
|
keymanapp-test-bot
bot
removed
the
user-test-required
jahorton
approved these changes
Sep 3, 2025
| getTheme().resolveAttribute(android.R.attr.actionBarSize, outValue, true); | ||
| int actionBarHeight = getResources().getDimensionPixelSize(outValue.resourceId); | ||
|
|
||
| // *** TO DO: Try to check if status bar is visible, set statusBarHeight to 0 if it is not visible *** |
Contributor
Author
There was a problem hiding this comment.
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.113-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14677
This updates the KMSample1 app with several of the fixes in the Keyman for Android app for handling device orientation changes. (notably part of #8704)
The text area also needs to be resized to accommodate banner/keyboard dimensions which are different between portrait and landscape orientation.
User Testing
Setup - Install the PR build of KMSample1 on an Android device/emulator