fix(web): fix error trying to calculate style scaling effects#14684
Merged
ermshiperete merged 2 commits intomasterfrom Sep 8, 2025
Merged
fix(web): fix error trying to calculate style scaling effects#14684ermshiperete merged 2 commits intomasterfrom
ermshiperete merged 2 commits intomasterfrom
Conversation
PR #13860 fixed a similar error by adding a check for NaN. However, it missed doing it for `layoutWidth` and only changed `layoutHeight`. This PR adds a similar check to `layoutWidth` and will thus fix the error we're still seeing in Sentry. Also add unit tests for both methods. User Testing ============ TEST_INUKTITUT_KEYBOARD: Using Keyman for Android, install the `inuktitut_pirurvik` and verify that no error notifications appear. Fixes: #14108 Fixes: [KEYMAN-WEB-RA](https://keyman.sentry.io/issues/6579536471/?referrer=github_integration)
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions Test Artifacts
|
keymanapp-test-bot
bot
added
has-user-test
user-test-required
darcywong00
reviewed
Sep 5, 2025
| if (this.usesFixedWidthScaling) { | ||
| let baseWidth = this.width; | ||
| baseWidth -= this._borderWidth * 2; | ||
| baseWidth = (isNaN(baseWidth) || baseWidth < 0) ? 0 : baseWidth; |
Contributor
There was a problem hiding this comment.
Does get internalHeight() (l.820) have a similar pattern to check?
Member
There was a problem hiding this comment.
Does a baseWidth of zero actually make sense?
Contributor
Author
There was a problem hiding this comment.
Good question. @jahorton Do you have any insights on that?
Contributor
There was a problem hiding this comment.
I think this scenario generally reflects when Keyman Engine for Web is still initializing - or perhaps if the hosting WebView has been backgrounded temporarily, before it's fully back in the view hierarchy. If memory serves, the correct values generally come through pretty quickly thereafter.
Contributor
Test ResultsBefore testing:
|
keymanapp-test-bot
bot
removed
the
user-test-required
mcdurdin
approved these changes
Sep 5, 2025
| if (this.usesFixedWidthScaling) { | ||
| let baseWidth = this.width; | ||
| baseWidth -= this._borderWidth * 2; | ||
| baseWidth = (isNaN(baseWidth) || baseWidth < 0) ? 0 : baseWidth; |
Member
There was a problem hiding this comment.
Does a baseWidth of zero actually make sense?
The same error could potentially happen in `internalHeight`, so we add the check for NaN there as well. Addresses code review comments.
ermshiperete
commented
Sep 5, 2025
| it('calculates InternalHeight correctly for number', () => { | ||
| const vk = createVisualKeyboard(); | ||
| vk['_height'] = 100; | ||
| assert.equal(vk.internalHeight.val, 88); |
Contributor
Author
There was a problem hiding this comment.
@jahorton The values we get from internalHeight look wrong since we're subtracting the borders twice. Or is that intentional?
ermshiperete
added a commit
that referenced
this pull request
Sep 5, 2025
PR #13860 fixed a similar error by adding a check for NaN. However, it missed doing it for `layoutWidth` and only changed `layoutHeight`. This PR adds a similar check to `layoutWidth` and will thus fix the error we're still seeing in Sentry. The same error could potentially happen in `internalHeight`, so we add the check for NaN there as well. Addresses code review comments. Also add unit tests for all three methods. # User Testing TEST_INUKTITUT_KEYBOARD: Using Keyman for Android, install the `inuktitut_pirurvik` and verify that no error notifications appear. Fixes: #14108 Fixes: [KEYMAN-WEB-RA](https://keyman.sentry.io/issues/6579536471/?referrer=github_integration) Cherry-pick-of: #14684
ermshiperete
added a commit
that referenced
this pull request
Sep 8, 2025
PR #13860 fixed a similar error by adding a check for NaN. However, it missed doing it for `layoutWidth` and only changed `layoutHeight`. This PR adds a similar check to `layoutWidth` and `internalHeight` and will thus fix the error we're still seeing in Sentry. Also add unit tests for all three methods. Fixes: #14108 Fixes: [KEYMAN-WEB-RA](https://keyman.sentry.io/issues/6579536471/?referrer=github_integration) Cherry-pick-of: #14684
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.114-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13860 fixed a similar error by adding a check for NaN. However, it missed doing it for
layoutWidthand only changedlayoutHeight.This PR adds a similar check to
layoutWidthand will thus fix the error we're still seeing in Sentry.Also add unit tests for both methods.
User Testing
TEST_INUKTITUT_KEYBOARD: Using Keyman for Android, install the
inuktitut_pirurvikand verify that no error notifications appear.Fixes: #14108
Fixes: KEYMAN-WEB-RA