maint(linux): allow to skip API check#14699
Merged
ermshiperete merged 2 commits intomasterfrom Sep 10, 2025
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
resources/
linux/
maint
ermshiperete
force-pushed
the
refactor/resources/shellcheck
branch
from
2ba64ff to
a9597b5
Compare
This change adds an option to skip the API checks during a build. This can be done by adding the trailer `Keyman-Api-Check: skip` to the PR description. Fixes: #10454 Test-bot: skip Keyman-Api-Check: skip
ermshiperete
force-pushed
the
maint/linux/10454_allowSkipAPI
branch
from
02ba8b3 to
612cd01
Compare
mcdurdin
approved these changes
Sep 8, 2025
|
|
||
| # | ||
| # Check the Keyman-Api-Check command whether or not to run API checks. | ||
| # Any value other than 'ignore' or no Keyman-Api-Check command will run |
Member
There was a problem hiding this comment.
Suggested change
| # Any value other than 'ignore' or no Keyman-Api-Check command will run | |
| # Any value other than 'skip' or no Keyman-Api-Check command will run |
| set -o noglob | ||
| IFS=$'\n' | ||
| prbody="$(echo "${prinfo}" | "${JQ}" -r '.body')" | ||
| prApiCheck="$(echo "${prbody}" | grep 'Keyman-Api-Check:' | cut -d: -f 2 - | tr -d '[:space:]')" |
Member
There was a problem hiding this comment.
I remember with Test-bot we had the problem that it didn't check start-of-line. Should we tweak our grep here?
Addresses code review comments. Co-Authored-By: Marc Durdin <marc@durdin.net>
Markus-SWAG
reviewed
Sep 9, 2025
Comment on lines
+58
to
+59
| prbody="$(echo "${prinfo}" | "${JQ}" -r '.body')" | ||
| prApiCheck="$(echo -e "${prbody}" | grep '^Keyman-Api-Check:' | cut -d: -f 2 - | tr -d '[:space:]')" |
Contributor
There was a problem hiding this comment.
Suggested change
| prbody="$(echo "${prinfo}" | "${JQ}" -r '.body')" | |
| prApiCheck="$(echo -e "${prbody}" | grep '^Keyman-Api-Check:' | cut -d: -f 2 - | tr -d '[:space:]')" | |
| prApiCheck="$(echo "${prinfo}" | "${JQ}" '.body["Keyman-Api-Check"]')" |
Contributor
Author
There was a problem hiding this comment.
Unfortunately the suggestion doesn't work.
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.116-alpha |
ermshiperete
added a commit
that referenced
this pull request
Sep 17, 2025
Fix broken test build trigger for `master` branch Follows: #14699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an option to skip the API checks during a build. This can be done by adding the trailer
Keyman-Api-Check: skipto the PR description.Fixes: #10454
Test-bot: skip
Keyman-Api-Check: skip