Conversation
…ks and log Fixes: #14731 Build-bot: skip Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
approved these changes
Sep 11, 2025
| local SCRIPT_CLONE=$(sed -n '/CLONE:START/,/CLONE:END/{//!p}' < "$MJS_FILE") | ||
| local SCRIPT_SUFFIX=$(sed -n '/CLONE-COMMENTED:START/,/CLONE-COMMENTED:END/{//!p}' < "$MJS_FILE" | sed 's/\/\/ //g') | ||
| echo -e "# GENERATED FILE - DO NOT EDIT!\n$YML_PREFIX\n$SCRIPT_CLONE\n$SCRIPT_SUFFIX\n" > "$YML_FILE" | ||
| echo $'# GENERATED FILE - DO NOT EDIT!\n'"$YML_PREFIX"$'\n'"$SCRIPT_CLONE"$'\n'"$SCRIPT_SUFFIX"$'\n' > "$YML_FILE" |
Contributor
There was a problem hiding this comment.
I'm always learning something new 😄
mcdurdin
deleted the
fix/resources/14731-pr-build-status-ignoring-failure-state
branch
Member
Author
|
Ah, I updated the .yml but not the .mjs, will revisit this shortly |
mcdurdin
added a commit
that referenced
this pull request
Sep 11, 2025
Follows: #14732 Build-bot: skip Test-bot: skip
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.117-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14731
Build-bot: skip
Test-bot: skip