Skip to content

fix(common): merging build and publish step for docker#14747

Merged
Markus-SWAG merged 1 commit intomasterfrom
fix/common/merging-build-and-publish-step-for-docker
Sep 12, 2025
Merged

fix(common): merging build and publish step for docker#14747
Markus-SWAG merged 1 commit intomasterfrom
fix/common/merging-build-and-publish-step-for-docker

Conversation

@Markus-SWAG
Copy link
Copy Markdown
Contributor

@Markus-SWAG Markus-SWAG commented Sep 12, 2025

Build and push are now in one job in the build, test, publish Docker images GitHub workflow.
By default the local image registry is not available from different jobs.
Uploading and downloading the images to transfer them between the jobs
seems to be an extra effort not being worth it.

Test-bot: skip
Build-bot: skip

… images workflow

By default the local image registry is not available from different jobs.
Uploading and downloading the images to transfer them between the jobs
seems to be an extra effort not being worth it.

Relates-To: #13594
Test-bot: skip
Build-bot: skip
@github-project-automation github-project-automation bot moved this to Todo in Keyman Sep 12, 2025
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Sep 12, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Sep 12, 2025

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S11 milestone Sep 12, 2025
@github-actions github-actions bot added the fix label Sep 12, 2025
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Sep 12, 2025
@mcdurdin mcdurdin changed the title fix: merging build and publish step for docker fix(linux): merging build and publish step for docker Sep 12, 2025
@mcdurdin mcdurdin changed the title fix(linux): merging build and publish step for docker fix(common): merging build and publish step for docker Sep 12, 2025
Copy link
Copy Markdown
Contributor

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Markus-SWAG Markus-SWAG merged commit da78788 into master Sep 12, 2025
7 checks passed
@Markus-SWAG Markus-SWAG deleted the fix/common/merging-build-and-publish-step-for-docker branch September 12, 2025 13:32
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Sep 12, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.118-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants