maint(linux): improve getting PR# in upload-to-debian.sh 🍒 🏠#14785
Merged
ermshiperete merged 2 commits intostable-18.0from Sep 22, 2025
Merged
maint(linux): improve getting PR# in upload-to-debian.sh 🍒 🏠#14785ermshiperete merged 2 commits intostable-18.0from
upload-to-debian.sh 🍒 🏠#14785ermshiperete merged 2 commits intostable-18.0from
Conversation
With this change we wait two seconds after creating the PR before trying to get the number of the PR so that GitHub can catch up. Previously recently it wasn't able to get the PR#. Also adjust the commit message and use the new header for skipping tests. Cherry-pick-of: #13890 Build-bot: skip Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
github-actions
bot
added
linux/
cherry-pick
keymanapp-test-bot
bot
changed the title
upload-to-debian.sh 🍒upload-to-debian.sh 🍒 🏠
mcdurdin
requested changes
Sep 18, 2025
linux/scripts/upload-to-debian.sh
Outdated
Comment on lines
111
to
113
| ${NOOP} gh pr create --draft --base "${BASE}" --title "${PR_TITLE}" --body "${PR_BODY}" | ||
| sleep 2s | ||
| PR_NUMBER=$(gh pr list --draft --search "${PR_TITLE}" --base "${BASE}" --json number --jq '.[].number') |
Member
There was a problem hiding this comment.
From https://cli.github.com/manual/gh_pr_create:
Upon success, the URL of the created pull request will be printed.
Could we just parse that out? It should be easy enough because the URL is pretty stable, e.g.:
https://github.com/keymanapp/keyman/pull/14785
Suggested change
| ${NOOP} gh pr create --draft --base "${BASE}" --title "${PR_TITLE}" --body "${PR_BODY}" | |
| sleep 2s | |
| PR_NUMBER=$(gh pr list --draft --search "${PR_TITLE}" --base "${BASE}" --json number --jq '.[].number') | |
| PR_URL=$(gh pr create --draft --base "${BASE}" --title "${PR_TITLE}" --body "${PR_BODY}") | |
| PR_NUMBER="${PR_URL##*/}" |
I am not sure about the NOOP interactions, but then on a no-op, isn't getting PR_NUMBER going to fall over anyway?
Contributor
Author
There was a problem hiding this comment.
Excellent idea to do it this way. I didn't know/notice that it only spits out the URL if you assign it to a variable.
Comment on lines
+200
to
+201
| "Cherry-pick-of: #${PR_NUMBER} | ||
| Test-bot: skip" |
Member
There was a problem hiding this comment.
Do you want to add Build-bot commands too? Is a build needed?
linux/scripts/upload-to-debian.sh
Outdated
| COMMIT_MESSAGE="chore(linux): Update debian changelog" | ||
| git commit -m "${COMMIT_MESSAGE}" | ||
| push_to_github_and_create_pr chore/linux/changelog "${DEPLOY_BRANCH#origin/}" "${COMMIT_MESSAGE}" "@keymanapp-test-bot skip" | ||
| push_to_github_and_create_pr chore/linux/changelog "${DEPLOY_BRANCH#origin/}" "${COMMIT_MESSAGE} 🏠" "Test-bot: skip" |
- directly get PR# from `gh pr create` - add `Build-bot: skip` trailers Build-bot: skip Test-bot: skip
Collaborator
|
Changes in this pull request will be available for download in Keyman version 18.0.242 |
cvosoft
pushed a commit
to cvosoft/keyman
that referenced
this pull request
Oct 23, 2025
- directly get PR# from `gh pr create` - add `Build-bot: skip` trailers - 🍒-pick of the improved 🍒-pick keymanapp#14785 Cherry-pick-of: keymanapp#14785 Build-bot: skip Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we wait two seconds after creating the PR before trying to get the number of the PR so that GitHub can catch up. Previously recently it wasn't able to get the PR#.
Also adjust the commit message and use the new header for skipping tests.
Cherry-pick-of: #13890
Build-bot: skip
Test-bot: skip