Conversation
User Test ResultsTest specification and instructions Test Artifacts
|
github-actions
bot
added
windows/
developer/
developer/ide/
windows/config/
windows/engine/
resources/
change
Base automatically changed from
feat/windows/14787-improve-startup-time
to
master
September 26, 2025 07:09
mcdurdin
force-pushed
the
change/windows/include-map2pdb-for-relevant-projects
branch
from
120cb60 to
eee2712
Compare
mcdurdin
force-pushed
the
change/windows/include-map2pdb-for-relevant-projects
branch
from
eee2712 to
a54cbf7
Compare
keymanapp-test-bot
bot
added
has-user-test
user-test-required
Member
Author
|
Both the Windows and the Developer installers are currently broken in this PR. Something has changed about how they are constructed. Investigating. |
mcdurdin
force-pushed
the
change/windows/include-map2pdb-for-relevant-projects
branch
from
a54cbf7 to
64101eb
Compare
Adds a call to map2pdb for Delphi projects, if map2pdb is an executable on the path. This way, we get .pdb files we can use for debugging and for performance profiling. This also replaces tds2dbg. If map2dbg is available, then the build and install actions will copy the PDB to be alongside the corresponding executable, making most debug actions relatively seamless for finding symbols. Also fixes up setup.exe in Windows and Developer to extend setup.exe to a 512-byte boundary after map2pdb patches the PE. Relates-to: #14787 Build-bot: skip release:developer,windows Test-bot: skip
mcdurdin
force-pushed
the
change/windows/include-map2pdb-for-relevant-projects
branch
from
64101eb to
edca16f
Compare
mcdurdin
changed the base branch from
master
to
fix/windows/stop-outputting-debug-strings-from-dllmain
Contributor
Test Specifications
Prerequisites
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
Member
Author
|
@rc-swag once this merges, we will need to check the pdb upload to sentry on the next alpha build and verify that symbols are being mapped correctly. |
mcdurdin
commented
Nov 17, 2025
Comment on lines
+33
to
+36
| reg add 'HKLM\SYSTEM\CurrentControlSet\services\eventlog\Application\Keyman' //v CategoryCount //t REG_DWORD //d 1 //f | ||
| reg add 'HKLM\SYSTEM\CurrentControlSet\services\eventlog\Application\Keyman' //v CategoryMessageFile //t REG_SZ //d "$INSTALLPATH_KEYMANENGINE\\keymanmc.dll" //f | ||
| reg add 'HKLM\SYSTEM\CurrentControlSet\services\eventlog\Application\Keyman' //v EventMessageFile //t REG_SZ //d "$INSTALLPATH_KEYMANENGINE\\keymanmc.dll" //f | ||
| reg add 'HKLM\SYSTEM\CurrentControlSet\services\eventlog\Application\Keyman' //v TypesSupported //t REG_DWORD //d 7 //f |
Member
Author
There was a problem hiding this comment.
Not related to map2pdb; discovered when running build.sh install, strings were incorrect.
Base automatically changed from
fix/windows/stop-outputting-debug-strings-from-dllmain
to
master
November 17, 2025 16:02
mcdurdin
deleted the
change/windows/include-map2pdb-for-relevant-projects
branch
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.163-alpha |
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a call to map2pdb for Delphi projects, if map2pdb is an executable on the path. This way, we get .pdb files we can use for debugging and for performance profiling. We may be able to use these in future also for Sentry traces and eliminate tds2dbg, but I will revisit that later.
If map2dbg is available, then the build and install actions will copy the PDB to be alongside the corresponding executable, making most debug actions relatively seamless for finding symbols.
Relates-to: #14787
Build-bot: skip release:developer,windows
User Testing
TEST_WINDOWS: Run through a set of standard Keyman for Windows tasks and verify that you do not experience any crashes.
TEST_DEVELOPER: Run through a set of standard Keyman Developer tasks and verify that you do not experience any crashes.