Skip to content

Conversation

@jahorton
Copy link
Contributor

@jahorton jahorton commented Sep 19, 2025

This PR adds a method that can determine which parts of a Transform's .insert component landed within each post-application "token" of the context.

When updating our context state information in order to attempt reuse of prior calculations, we need to know where the input's components align with them so that they affect the predictive-text process correctly.

Note that the .deleteLeft component is instead determined when building the edge window, as it takes effect on the original state and tokenization of the context. (Of particular note here: if a token is fully deleted, there's no reason to preserve it - we can delete it instead [or replace it, if new text is set in the same place].)

Relates-to: #14679

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Sep 19, 2025

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(web): add helper for tokenizing Transform.insert via tokenization of applied context feat(web): add helper for tokenizing Transform.insert via tokenization of applied context 🚂 Sep 19, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S12 milestone Sep 19, 2025
@jahorton jahorton force-pushed the feat/web/backward-slide-tokenization branch from 8ca53ed to b1d3899 Compare September 22, 2025 14:32
…n of applied context

Relates-to: #14679

Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the feat/web/trace-insert-edits branch from 602d212 to 9ffc093 Compare September 22, 2025 14:35
@darcywong00 darcywong00 modified the milestones: A19S12, A19S13 Sep 27, 2025
@jahorton jahorton marked this pull request as ready for review September 30, 2025 14:34
Base automatically changed from feat/web/backward-slide-tokenization to epic/autocorrect October 6, 2025 14:51
@jahorton jahorton merged commit e8f28fd into epic/autocorrect Oct 6, 2025
7 of 8 checks passed
@jahorton jahorton deleted the feat/web/trace-insert-edits branch October 6, 2025 14:51
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants