feat(web): add helper for aligning tokens after merges, splits 🚂 #14806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
feat/web/trace-insert-edits
branch
from
602d212 to
9ffc093
Compare
Relates-to: #14679 Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
feat/web/compute-merge-split-effects
branch
from
22d168c to
7362d36
Compare
ermshiperete
approved these changes
Oct 1, 2025
web/src/engine/predictive-text/worker-thread/src/main/correction/context-tokenization.ts
Outdated
Show resolved
Hide resolved
web/src/engine/predictive-text/worker-thread/src/main/correction/context-tokenization.ts
Outdated
Show resolved
Hide resolved
ermshiperete
approved these changes
Oct 2, 2025
Base automatically changed from
feat/web/trace-insert-edits
to
epic/autocorrect
October 6, 2025 14:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling merges and splits can get a little tricky, so this PR adds a new helper method that will help determine what effects any merges and splits should have when updating context state and tokenization data during a context transition. Of particular note is
split- it is incredibly helpful to precompute the character index within the original token at which each split-off token should begin.Relates-to: #14679
Build-bot: skip build:web
Test-bot: skip