Skip to content

maint(windows): check code signatures only in CI builds#14815

Merged
mcdurdin merged 1 commit intomasterfrom
maint/windows/sign-check-only-in-ci
Sep 25, 2025
Merged

maint(windows): check code signatures only in CI builds#14815
mcdurdin merged 1 commit intomasterfrom
maint/windows/sign-check-only-in-ci

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

When building locally, code signatures will not have SIL in the name, so will fail the build. So skip checking code signatures on local builds.

Build-bot: skip release:windows,developer
Test-bot: skip

When building locally, code signatures will not have SIL in the name, so
will fail the build. So skip checking code signatures on local builds.

Build-bot: skip release:windows,developer
Test-bot: skip
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Sep 23, 2025

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S12 milestone Sep 23, 2025
@github-actions github-actions bot added resources/ maint Maintenance work -- continuous integration, build scripts, infrastructure windows/ labels Sep 23, 2025
Copy link
Copy Markdown
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit ec229c1 into master Sep 25, 2025
12 checks passed
@mcdurdin mcdurdin deleted the maint/windows/sign-check-only-in-ci branch September 25, 2025 03:48
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Sep 25, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.127-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maint Maintenance work -- continuous integration, build scripts, infrastructure resources/ windows/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants