maint(linux): allow to remote debug integration tests in Docker#14818
Merged
ermshiperete merged 3 commits intomasterfrom Sep 30, 2025
Merged
maint(linux): allow to remote debug integration tests in Docker#14818ermshiperete merged 3 commits intomasterfrom
ermshiperete merged 3 commits intomasterfrom
Conversation
This adds a `--remote-debug` option to `resources/docker-images/run.sh`. If specified the container will expose `localhost:2345` for remote debugging inside of the container. This is useful for debugging integration tests in the container. Build-bot: skip Test-bot: skip
github-actions
bot
added
linux/
linux/engine/
docs
resources/
maint
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
Sep 25, 2025
| "--registry=REGISTRY The container registry to keep the images (default: ghcr.io/keymanapp)" \ | ||
| "--username=REGISTRY_USERNAME The user for the container registry (default: keymanapp)" \ | ||
| "--password=REGISTRY_PASSWORD The password for the container registry user (default: password)" \ | ||
| "--remote-debug Expose the container's port 2345 for remote debugging" |
Contributor
There was a problem hiding this comment.
Does this get documented at https://github.com/keymanapp/keyman/tree/master/resources/docker-images#running-tests-locally ?
Contributor
There was a problem hiding this comment.
It is documented right below: https://github.com/keymanapp/keyman/tree/master/resources/docker-images#using-a-docker-container-registry
Contributor
There was a problem hiding this comment.
ic. with the new --remote-debug parameter though?
ermshiperete
force-pushed
the
maint/linux/remotedbgdocker
branch
from
ba22207 to
cca4a50
Compare
…/linux/remotedbgdocker
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.130-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
--remote-debugoption toresources/docker-images/run.sh. If specified the container will exposelocalhost:2345for remote debugging inside of the container.This is useful for debugging integration tests in the container.
Build-bot: skip
Test-bot: skip