Skip to content

maint(linux): remove several shellcheck directives#14819

Merged
ermshiperete merged 1 commit intomasterfrom
maint/linux/shellcheck
Sep 24, 2025
Merged

maint(linux): remove several shellcheck directives#14819
ermshiperete merged 1 commit intomasterfrom
maint/linux/shellcheck

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

This change improves our .shellcheckrc file so that several directives are no longer needed and source files are still found. Also remove some directives that are no longer necessary, either because the changes to .shellcheckrc makes them obsolete, or because the lines changed so that they no longer contain the problem.

Build-bot: skip
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S12 milestone Sep 23, 2025
@github-actions github-actions bot added the maint Maintenance work -- continuous integration, build scripts, infrastructure label Sep 23, 2025
This change improves our `.shellcheckrc` file so that several directives
are no longer needed and source files are still found. Also remove some
directives that are no longer necessary, either because the changes to
`.shellcheckrc` makes them obsolete, or because the lines changed so
that they no longer contain the problem.

Also remove some shellcheck warnings.

Build-bot: skip
Test-bot: skip
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ermshiperete ermshiperete merged commit 5cff28d into master Sep 24, 2025
6 checks passed
@ermshiperete ermshiperete deleted the maint/linux/shellcheck branch September 24, 2025 06:14
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Sep 24, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.126-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs linux/engine/ linux/ maint Maintenance work -- continuous integration, build scripts, infrastructure resources/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants