refactor(web): cleanup in test scripts ☕#14870
Merged
ermshiperete merged 3 commits intomasterfrom Oct 2, 2025
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
web/
common/
common/web/
web/predictive-text/
resources/
refactor
labels
Also use common function for running web types tests. Test-bot: skip
ermshiperete
force-pushed
the
refactor/web/testscripts
branch
from
f288a3e to
34c43b1
Compare
ermshiperete
changed the title
jahorton
approved these changes
Oct 1, 2025
mcdurdin
approved these changes
Oct 2, 2025
resources/build/typescript.inc.sh
Outdated
Comment on lines
+27
to
+28
| builder_echo error "No test/ or tests/ directory found." | ||
| return 1 |
Member
There was a problem hiding this comment.
Just builder_die would work here?
Comment on lines
+22
to
+25
| if [[ -d test/ ]]; then | ||
| TEST_DIR="test/" | ||
| elif [[ -d tests/ ]]; then | ||
| TEST_DIR="tests/" |
Member
There was a problem hiding this comment.
More cleanup required at some point!
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.131-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also use common function for running web types tests.
Test-bot: skip