Skip to content

fix(android): Convert longpress delay menu to ConstraintLayout#14897

Merged
darcywong00 merged 1 commit intomasterfrom
fix/android/longpress-menubar
Oct 8, 2025
Merged

fix(android): Convert longpress delay menu to ConstraintLayout#14897
darcywong00 merged 1 commit intomasterfrom
fix/android/longpress-menubar

Conversation

@darcywong00
Copy link
Copy Markdown
Contributor

Fixes #14887

The "Adjust longpress delay" menu got missed in #14463 in converting Activities from RelativeLayout to ConstraintLayout to handle Android's edge-to-edge behavior. The activity also needed the setupEdgeToEdge() call.

Screenshot with change

Screenshot_20251007_142851

User Testing

Setup - Install the PR build of Keyman for Android on emulator/device with a camera notch (e.g. Pixel 8+)

  • TEST_ADJUST_LONGPRESS_MENU - verifies Adjust "Longpress Delay menu" not impacted by camera notch
  1. Launch Keyman for Android in portrait orientation and dismiss the "Get Started" menu
  2. From Keyman settings --> Adjust longpress delay
  3. Verify on the "Adjust Longpress Delay" menu:
    a. status icons appear above the title bar
    a. title bar not covered by the camera notch
    c. the Longpress delay time can be adjusted

@darcywong00 darcywong00 added this to the A19S13 milestone Oct 7, 2025
@github-project-automation github-project-automation bot moved this to Todo in Keyman Oct 7, 2025
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Oct 7, 2025
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Oct 7, 2025

@Nnyny
Copy link
Copy Markdown
Contributor

Nnyny commented Oct 8, 2025

Test Results

Before testing:
- Install keyman-19.0.134-alpha-test-14897.apk

  • TEST_ADJUST_LONGPRESS_MENU (PASSED): notes
  1. Launch Keyman 19.0.134-alpha-test-14897 and dismiss the 'Get Started' menu
  2. Go to Setting > Adjust longpress delay
  3. Verify the UI isn't block by icons or the camera and the delay time works correctly

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Oct 8, 2025
@darcywong00 darcywong00 merged commit 6ee3817 into master Oct 8, 2025
8 checks passed
@darcywong00 darcywong00 deleted the fix/android/longpress-menubar branch October 8, 2025 08:24
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Oct 8, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.135-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug(Android): Adjust long-press delay" overlapped on the camera notch

4 participants