maint(resources): Docker container changes permissions to match the file owner uid and gid#14900
Merged
Markus-SWAG merged 6 commits intomasterfrom Nov 4, 2025
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
changed the title
Contributor
|
What uid/gid do we get if we run this as GHA? |
ermshiperete
reviewed
Oct 9, 2025
| uid=\$(stat -c "%u" /home/build/build) | ||
| gid=\$(stat -c "%g" /home/build/build) | ||
|
|
||
| if [[ "\${uid}" != "\$(id -u)" || "\${gid}" != "\$(id -g)" ]]; then |
Contributor
There was a problem hiding this comment.
I think this can be
Suggested change
| if [[ "\${uid}" != "\$(id -u)" || "\${gid}" != "\$(id -g)" ]]; then | |
| if [[ "\${uid}" != "\$(id -u)" && "\${gid}" != "\$(id -g)" ]]; then |
It is sufficient if either the user or the group matches.
| "\${@:-bash}" | ||
| fi | ||
|
|
||
| if [[ "\${uid}" != "\$(id -u)" || "\${gid}" != "\$(id -g)" ]]; then |
Contributor
There was a problem hiding this comment.
Suggested change
| if [[ "\${uid}" != "\$(id -u)" || "\${gid}" != "\$(id -g)" ]]; then | |
| if [[ "\${uid}" != "\$(id -u)" && "\${gid}" != "\$(id -g)" ]]; then |
There is an issue that the Docker containers cannot modify the files on KEYMAN_ROOT, since the user running build and tests on Docker does not have the same gid and uid as the host user starting the container. The issue is solved by temporarily changing the uid and gid to match the container user's uid and gid. Test-bot: skip Build-bot: skip
Markus-SWAG
force-pushed
the
fix/common/match-container-permissions
branch
from
70b02d1 to
c9b44d3
Compare
github-actions
bot
added
the
maint
Test-bot: skip Build-bot: skip
ermshiperete
approved these changes
Nov 4, 2025
Forgotten to remove when CHANGE_PERMISSIONS was invented. Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.156-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue that the Docker containers cannot modify the
files on KEYMAN_ROOT, since the user running build and tests on
Docker does not have the same gid and uid as the host user starting
the container.
The issue is solved by temporarily changing the uid and gid to
match the container user's uid and gid.
Test-bot: skip
Build-bot: skip