refactor(web): convert main correction-search method to accept multiple search-spaces 🚂#14903
Merged
jahorton merged 2 commits intoepic/autocorrectfrom Jan 28, 2026
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
5032faf to
0d6ed48
Compare
jahorton
changed the base branch from
change/web/remove-tracker-analyze-state
to
feat/web/search-space-identifiers
jahorton
force-pushed
the
feat/web/search-space-identifiers
branch
from
11cf559 to
ff8d585
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
fcab0aa to
02b9293
Compare
jahorton
changed the base branch from
feat/web/search-space-identifiers
to
refactor/web/search-batcher
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
02b9293 to
96a4b99
Compare
jahorton
changed the base branch from
refactor/web/search-batcher
to
refactor/web/use-interface-as-search-parent
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
30f660a to
604ee6c
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
96a4b99 to
3fe8645
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
604ee6c to
1f69bba
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
3fe8645 to
de3d86c
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
1f69bba to
7b67bc5
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
de3d86c to
0fdd522
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
from
f0978aa to
c28bb20
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
0fdd522 to
9507c71
Compare
jahorton
force-pushed
the
refactor/web/use-interface-as-search-parent
branch
7 times, most recently
from
28ded16 to
3a56e23
Compare
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
851fb77 to
1ee5cc2
Compare
jahorton
changed the base branch from
refactor/web/use-interface-as-search-parent
to
refactor/web/differentiate-module-types
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
1ee5cc2 to
c81f1f7
Compare
Base automatically changed from
refactor/web/differentiate-module-types
to
epic/autocorrect
January 22, 2026 16:21
…le spaces Build-bot: skip build:web Test-bot: skip
jahorton
force-pushed
the
refactor/web/multi-space-correction-search
branch
from
52aca11 to
ceabe5a
Compare
web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts
Outdated
Show resolved
Hide resolved
web/src/engine/predictive-text/worker-thread/src/main/correction/distance-modeler.ts
Outdated
Show resolved
Hide resolved
ermshiperete
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR's changes allow the main suggestion-generation method to source suggestions from multiple different search-space objects, rather than just one. This, in turn, will help the engine to consider possible alternate word-breaking scenarios - though much more work is needed to actually do this.
Build-bot: skip build:web
Test-bot: skip