fix(mac): ignore non-Unicode key caps when preparing OSK#15008
Merged
fix(mac): ignore non-Unicode key caps when preparing OSK#15008
Conversation
The typeFlags property is used to differentiate Unicode and non-Unicode keys in the array of keys in a .kvk file. All non-Unicode keys should be ignored, as we do not support non-Unicode keyboards on macOS. The reason this fixes #15007, is that the keyboard in question had both ANSI and Unicode sections in its .kvk file, and the ANSI section was stored after the Unicode section, so the font spec for ANSI was overriding the previously (correctly) set Unicode font spec. Fixes: #15007
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts |
mcdurdin
added a commit
that referenced
this pull request
Oct 24, 2025
The typeFlags property is used to differentiate Unicode and non-Unicode keys in the array of keys in a .kvk file. All non-Unicode keys should be ignored, as we do not support non-Unicode keyboards on macOS. The reason this fixes #15007, is that the keyboard in question had both ANSI and Unicode sections in its .kvk file, and the ANSI section was stored after the Unicode section, so the font spec for ANSI was overriding the previously (correctly) set Unicode font spec. Fixes: #15007 Cherry-pick-of: #15008 Test-bot: skip
Contributor
Test Results
OSK now displays correctly with 'Galaxie Hebrew (Mnemonic)' keyboard: 
|
keymanapp-test-bot
bot
removed
the
user-test-required
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.146-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typeFlags property is used to differentiate Unicode and non-Unicode keys in the array of keys in a .kvk file. All non-Unicode keys should be ignored, as we do not support non-Unicode keyboards on macOS.
The reason this fixes #15007, is that the keyboard in question had both ANSI and Unicode sections in its .kvk file, and the ANSI section was stored after the Unicode section, so the font spec for ANSI was overriding the previously (correctly) set Unicode font spec.
Fixes: #15007
User Testing
TEST_OSK_GALAXIE_HEBREW: Verify that the Galaxie Hebrew Mnemonic keyboard now displays in the OSK correctly on macOS