Skip to content

maint(resources): use actions/setup-node to upgrade npm#15035

Merged
mcdurdin merged 1 commit intomasterfrom
maint/resources/npm-publish-npm-i-non-global
Oct 28, 2025
Merged

maint(resources): use actions/setup-node to upgrade npm#15035
mcdurdin merged 1 commit intomasterfrom
maint/resources/npm-publish-npm-i-non-global

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Oct 28, 2025

We don't have permissions to use npm install --global npm to get a specific version, but this action is supported by GH so should be fine.

It remains to be seen if there will be other compatibility issues due to being a later version of Node than what we are using in v19.

Follows: #15029
Build-bot: skip
Test-bot: skip

We don't have permissions to use `npm install --global npm` to get a
specific version, but this action is supported by GH so should be fine.

It remains to be seen if there will be other compatibility issues due to
being a later version of Node than what we are using in v19.

Build-bot: skip
Test-bot: skip
@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S15 milestone Oct 28, 2025
@github-actions github-actions bot added maint Maintenance work -- continuous integration, build scripts, infrastructure resources/ labels Oct 28, 2025
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@mcdurdin mcdurdin merged commit 9f521cf into master Oct 28, 2025
7 checks passed
@mcdurdin mcdurdin deleted the maint/resources/npm-publish-npm-i-non-global branch October 28, 2025 07:49
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Oct 28, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.147-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maint Maintenance work -- continuous integration, build scripts, infrastructure resources/

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants