maint(resources): npm publish - build all packages first#15042
Merged
maint(resources): npm publish - build all packages first#15042
Conversation
github-actions
bot
added
resources/
maint
User Test ResultsTest specification and instructions User tests are not required |
jahorton
approved these changes
Oct 28, 2025
Also splits the build and publish steps so all packages are built before first is published, as publishing stomps on package.json files, which makes subsequent builds trickier. This needs to be merged to master in order for the action steps to pass. Build-bot: skip Test-bot: skip
I am not entirely clear why the coverage dropped, but I suspect it's due to code paths that are not activated in node 24. For now, just dropping coverage threshold to 40%.
If the repository is a shallow checkout, then the only commit will be the most recent one, and the test will fail. We could lookup the date of the most recent test, but it's a pretty meaningless test, so instead we will skip the test in this scenario. For example, this happens on GitHub Actions when we do a shallow checkout. The only risk we have is if we move all builds to shallow checkouts and end up always skipping this test, but (a) the code is unlikely to change, and (b) issuse would be picked up on local builds in that situation pretty quickly.
mcdurdin
force-pushed
the
maint/resources/npm-publish-build-all-packages-first
branch
from
7a10711 to
1251189
Compare
mcdurdin
deleted the
maint/resources/npm-publish-build-all-packages-first
branch
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.148-alpha |
mcdurdin
added a commit
that referenced
this pull request
Oct 30, 2025
If the repository is a shallow checkout, then the only commit will be the most recent one, and the test will fail. We could lookup the date of the most recent test, but it's a pretty meaningless test, so instead we will skip the test in this scenario. For example, this happens on GitHub Actions when we do a shallow checkout. The only risk we have is if we move all builds to shallow checkouts and end up always skipping this test, but (a) the code is unlikely to change, and (b) issuse would be picked up on local builds in that situation pretty quickly. Cherry-pick-of: #15042
mcdurdin
added a commit
that referenced
this pull request
Oct 30, 2025
I am not entirely clear why the coverage dropped, but I suspect it's due to code paths that are not activated in node 24. For now, just dropping coverage threshold to 40%. Cherry-pick-of: #15042
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few bundled changes for npm-publish here:
Follows: #15029
Build-bot: skip
Test-bot: skip