maint(resources): add build timing report to builder#15114
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
resources/
maint
mcdurdin
force-pushed
the
maint/resources/builder-timing
branch
from
cb54121 to
41e2504
Compare
mcdurdin
force-pushed
the
maint/resources/builder-timing
branch
3 times, most recently
from
593671a to
ef1f93b
Compare
mcdurdin
force-pushed
the
maint/resources/builder-timing
branch
2 times, most recently
from
3e52d90 to
9f47893
Compare
This is enabled automatically for CI builds, and can be enabled with `--timing` parameter otherwise. Also, adds `builder_launch`, documentation to come. Test-bot: skip
mcdurdin
force-pushed
the
maint/resources/builder-timing
branch
from
9f47893 to
c573709
Compare
mcdurdin
commented
Nov 10, 2025
| STATUS_CONTEXT: 'Ubuntu Packaging' | ||
| DEBFULLNAME: 'Keyman GHA packager' | ||
| DEBEMAIL: 'support@keyman.com' | ||
| _builder_timings: false |
Member
Author
There was a problem hiding this comment.
For Debian packaging, we turn off builder timings; also done in the .sh
ermshiperete
approved these changes
Nov 10, 2025
Comment on lines
+810
to
+814
| if(!mod) { | ||
| console.error(`START not found for ${area}`); | ||
| } else { | ||
| mod.stop = parseFloat(time); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if(!mod) { | |
| console.error(`START not found for ${area}`); | |
| } else { | |
| mod.stop = parseFloat(time); | |
| } | |
| if(mod) { | |
| mod.stop = parseFloat(time); | |
| } else { | |
| console.error(`START not found for ${area}`); | |
| } |
Member
Author
There was a problem hiding this comment.
Curious why this change?
Contributor
There was a problem hiding this comment.
IMO it's easier to read if the non-negated, default branch comes first.
Member
Author
There was a problem hiding this comment.
I see. I will leave it for now; I was going for the 'must pass preconditions' pattern but didn't quite reach it I guess!
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.162-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is enabled automatically for CI builds, and can be enabled with
--timingparameter otherwise. Also, addsbuilder_launch, documentation to come; see #15129. Documentation for--timingto be done in #15130.Test-bot: skip