Conversation
If the .keyman-touch-layout file has validation errors, Keyman Developer will now report the first validation error in the message window, rather than silently closing the whole keyboard editor. The .keyman-touch-layout file will be loaded in Code view, and once the first validation error is addressed, switching to Design view will report the next error. For future improvement: * reporting multiple validation errors * reporting line number of error Fixes: #15242 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Nov 27, 2025
|
|
||
| FTouchLayout := TTouchLayout.Create; // I3642 | ||
| try | ||
| FTouchLayout.OnMessage := TouchLayoutMessage; |
Contributor
There was a problem hiding this comment.
Where does the Message string get passed in?
Member
Author
There was a problem hiding this comment.
The message is written by TTouchLayout.DoMessage and TTouchLayout.DoError when an error is encountered, for example:
keyman/developer/src/tike/oskbuilder/TouchLayout.pas
Lines 335 to 336 in c02f5ab
mcdurdin
deleted the
fix/developer/15242-handle-errors-in-touch-layout-on-load
branch
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.168-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the .keyman-touch-layout file has validation errors, Keyman Developer will now report the first validation error in the message window, rather than silently closing the whole keyboard editor. The .keyman-touch-layout file will be loaded in Code view, and once the first validation error is addressed, switching to Design view will report the next error.
For future improvement:
Fixes: #15242
Test-bot: skip