change(windows): add unit testing to keyman32 build#15244
Merged
Conversation
Rename keyman-engine-tests.vcxproj to keyman32.tests.vcxproj, move up a folder, rename other files to match test filename conventions, update vcxproj for vs2022, and build and run this from build.sh:test. Also remove keyman-engine.vcxproj, instead integrating the static lib version of keyman32 into keyman32.vcxproj. One day in the future, we could split back the other way, and have the DLL be essentially a link action from the .lib, but that's higher complexity to setup. Add a configuration step to install NuGet packages for Google Test specifically for keyman32.tests.vcxproj. If we add Google Test to other msbuild projects, we could move the packages/ up to top level of the repo in the future (similar to node_modules) to reduce number of configuration downloads. Build-bot: skip build:windows,developer Test-bot: skip
github-actions
bot
added
windows/
windows/engine/
resources/
change
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
rc-swag
approved these changes
Nov 28, 2025
Contributor
rc-swag
left a comment
rc-swag
left a comment
There was a problem hiding this comment.
LGTM
this is going to be fun merging into epic/win-arm
Member
Author
Yeah, this was actually giving me pause on doing this, but I reckon I'll manage when I do the epic-master-merge next week |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.167-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename keyman-engine-tests.vcxproj to keyman32.tests.vcxproj, move up a folder, rename other files to match test filename conventions, update vcxproj for vs2022, and build and run this from build.sh:test.
Also remove keyman-engine.vcxproj, instead integrating the static lib version of keyman32 into keyman32.vcxproj. One day in the future, we could split back the other way, and have the DLL be essentially a link action from the .lib, but that's higher complexity to setup.
Add a configuration step to install NuGet packages for Google Test specifically for keyman32.tests.vcxproj. If we add Google Test to other msbuild projects, we could move the packages/ up to top level of the repo in the future (similar to node_modules) to reduce number of configuration downloads.
Build-bot: skip build:windows,developer
Test-bot: skip
Tests are running: