test(web): add baseline tests 🎼#15251
Merged
ermshiperete merged 2 commits intoepic/web-corefrom Dec 9, 2025
Merged
Conversation
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
changed the title
ermshiperete
force-pushed
the
test/web/baseline
branch
2 times, most recently
from
e5c0179 to
90d64be
Compare
ermshiperete
force-pushed
the
tests/web/e2ekmxkbds
branch
2 times, most recently
from
815e26f to
425d74c
Compare
ermshiperete
force-pushed
the
test/web/baseline
branch
from
90d64be to
bb52d1a
Compare
ermshiperete
force-pushed
the
tests/web/e2ekmxkbds
branch
from
425d74c to
e33dbc9
Compare
ermshiperete
force-pushed
the
test/web/baseline
branch
from
bb52d1a to
3033f90
Compare
keymanapp-test-bot
bot
removed
the
user-test-missing
ermshiperete
force-pushed
the
test/web/baseline
branch
from
3033f90 to
86ca22b
Compare
ermshiperete
force-pushed
the
tests/web/e2ekmxkbds
branch
from
e33dbc9 to
8ef8849
Compare
ermshiperete
force-pushed
the
test/web/baseline
branch
2 times, most recently
from
ef39302 to
924cb47
Compare
ermshiperete
force-pushed
the
tests/web/e2ekmxkbds
branch
from
8ef8849 to
12d5645
Compare
ermshiperete
force-pushed
the
test/web/baseline
branch
from
924cb47 to
8784e0a
Compare
mcdurdin
approved these changes
Dec 8, 2025
| ]); | ||
|
|
||
| // Tests that should work but fail due to not-yet implemented functionality | ||
| // TODO-web-core: fix these tests |
Comment on lines
+175
to
+178
| for (let i = 0; i < keySequence.length - 1; i++) { | ||
| await page.keyboard.down(keySequence[i]); | ||
| } | ||
| await page.keyboard.down(keySequence[keySequence.length - 1]); |
Member
There was a problem hiding this comment.
Why is the last line done separately outside the loop?
Contributor
Author
There was a problem hiding this comment.
Doesn't make sense, you're right. And I don't remember why I did it that way. Probably left-over from debugging.
Comment on lines
+180
to
+183
| await page.keyboard.up(keySequence[keySequence.length - 1]); | ||
| for (let i = keySequence.length - 2; i >= 0; i--) { | ||
| await page.keyboard.up(keySequence[i]); | ||
| } |
ermshiperete
commented
Dec 9, 2025
| // relative to the directory containing this config file. Using | ||
| // relative path so that the playwright vscode extension works correctly. | ||
| command: '../../../../build.sh start', | ||
| command: `${KEYMAN_ROOT}/web/build.sh start`, |
Contributor
Author
There was a problem hiding this comment.
This change was necessary to get it to work on Windows. Strange that it worked in the previous PR (#15250)...
Contributor
Author
There was a problem hiding this comment.
Oops - turns out it didn't work in the previous PR, I just forgot to try on Windows 😄
Comment on lines
+175
to
+178
| for (let i = 0; i < keySequence.length - 1; i++) { | ||
| await page.keyboard.down(keySequence[i]); | ||
| } | ||
| await page.keyboard.down(keySequence[keySequence.length - 1]); |
Contributor
Author
There was a problem hiding this comment.
Doesn't make sense, you're right. And I don't remember why I did it that way. Probably left-over from debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the baseline tests from
/common/test/keyboards/baseline. Some tests are skipped because they rely on functionality not implemented in Web, other tests are skipped because they require functionality still marked withTODO-web-coreand should pass once web-core is finished.Test-bot: skip