docs(ios): Use /cdn/dev assets for Engine guides#15253
Merged
darcywong00 merged 1 commit intomasterfrom Dec 1, 2025
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Dec 1, 2025
Member
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM - they weren't even the "good" deploy links, which are supposed to have an md5 hash in them for cache busting
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.168-alpha |
mcdurdin
pushed a commit
that referenced
this pull request
Dec 3, 2025
Cherry-pick-of: #15253 Test-bot: skip Build-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keymanapp/help.keyman.com#1615 converted the Keyman Engine for iPhone and iPad guides from PHP to Markdown, where image asset references changed from PHP
cdn()calls to Markdown image links to/cdn/deploy/.The Markdown references to /cdn/deploy assets work for production/staging tier, but that folder won't exist when the help.keyman.com site is built with
./build.sh build --debugSee https://github.com/keymanapp/help.keyman.com/blob/2eeb860a21c050d5c26e126841fee105d27ef1a2/resources/init-container.sh#L11-L20
This updates the iOS guides to use /cdn/dev assets (and will get synced to the /developer/engine/iphone-and-ipad/19.0/)
Test-bot: skip