maint(common): use builder_launch for child builds#15258
Merged
Conversation
github-actions
bot
added
web/
windows/
android/
developer/
ios/
linux/
common/
windows/config/
windows/engine/
resources/
labels
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
the
maint
Base automatically changed from
maint/core/15254-verify-changes-to-ldml-consts
to
master
December 2, 2025 04:28
mcdurdin
force-pushed
the
maint/common/15130-use-builder_launch-for-child-builds
branch
from
53f2dc0 to
50d12a5
Compare
Fixes: #15130 Test-bot: skip
mcdurdin
force-pushed
the
maint/common/15130-use-builder_launch-for-child-builds
branch
from
50d12a5 to
c524db4
Compare
mcdurdin
commented
Dec 2, 2025
Comment on lines
26
to
36
| function _build_sample1() { | ||
| builder_echo start "kmsample1" "Building KMSample1" | ||
| "${KEYMAN_ROOT}/ios/samples/KMSample1/build.sh" clean configure build --debug | ||
| builder_launch /ios/samples/KMSample1/build.sh clean configure build | ||
| builder_echo end "kmsample1" success "Finished building KMSample1" | ||
| } | ||
|
|
||
| function _build_sample2() { | ||
| builder_echo start "kmsample2" "Building KMSample2" | ||
| "${KEYMAN_ROOT}/ios/samples/KMSample2/build.sh" clean configure build --debug | ||
| builder_launch /ios/samples/KMSample2/build.sh clean configure build | ||
| builder_echo end "kmsample2" success "Finished building KMSample2" | ||
| } |
Member
Author
There was a problem hiding this comment.
The --debug flag has been set in the calling script in TeamCity directly, because these are setup only for debug builds at this point, without a development team and codesigning
Long-term builder_launch may need to handle the default action in child builds, but this is really an outlier and for now, fixing here. This resolves a situation where the unit tests were not running for web after the builder_launch update. Fixes: #15130 Build-bot: skip build:web
mcdurdin
commented
Dec 2, 2025
Comment on lines
-14
to
+16
| local ARGS="$2" | ||
|
|
||
| # REVIEW: is it deliberate that we `configure` all targets but only `build,test` `$TARGETS`? | ||
| "${KEYMAN_ROOT}/android/build.sh" configure build,test:"${TARGETS}" ${ARGS} | ||
| builder_launch /android/build.sh configure build,test:"${TARGETS}" |
Member
Author
There was a problem hiding this comment.
No ARGS are provided or needed after this update (was --debug)
Comment on lines
-110
to
+114
| android_build_action "${TARGETS}" --release | ||
| android_build_action "${TARGETS}" | ||
| do_publish | ||
| else | ||
| builder_run_action clean android_clean_action | ||
| builder_run_action build android_build_action "${TARGETS}" --release | ||
| builder_run_action build android_build_action "${TARGETS}" |
Member
Author
There was a problem hiding this comment.
--release is default in TC builds
Comment on lines
31
to
-32
| function do_build() { | ||
| "${KEYMAN_ROOT}/android/build.sh" \ |
Member
Author
There was a problem hiding this comment.
--debug flag is no longer required, was for Firebase in the past
Comment on lines
-42
to
+47
| android_build_action "${TARGETS}" --debug | ||
| android_publish_symbols "${TARGETS}" --debug | ||
| android_build_action "${TARGETS}" | ||
| android_publish_symbols "${TARGETS}" | ||
| else | ||
| builder_run_action clean android_clean_action | ||
| builder_run_action build android_build_action "${TARGETS}" --debug | ||
| builder_run_action publish android_publish_symbols "${TARGETS}" --debug | ||
| builder_run_action build android_build_action "${TARGETS}" | ||
| builder_run_action publish android_publish_symbols "${TARGETS}" |
Member
Author
There was a problem hiding this comment.
--debug flag is no longer required, was for firebase in the past
mcdurdin
commented
Dec 2, 2025
| # Run tests | ||
| builder_run_child_actions test | ||
| builder_run_action test:_all ./test.sh | ||
| builder_run_action test:_all builder_launch /web/test.sh test |
Member
Author
There was a problem hiding this comment.
builder_launch currently only supports build as a default parameter
mcdurdin
requested review from
ermshiperete and
jahorton
and removed request for
ermshiperete
darcywong00
reviewed
Dec 2, 2025
| # Embed tsysinfox64 into a resource; we have to do a special signcode for | ||
| # tsysinfox64.exe as we embed the executable into tsysinfo.exe | ||
| ../tsysinfox64/build.sh publish --no-deps | ||
| builder_launch /windows/src/engine/tsysinfox64/build.sh publish |
Contributor
There was a problem hiding this comment.
Is --no-deps still used?
Member
Author
There was a problem hiding this comment.
Not here, it's no longer required because builder_launch means that previously built deps would have already been tracked. So this is a bit of a win. Also, builder_launch does not permit the use of --no-deps as it's a reserved parameter for child script calls.
ermshiperete
approved these changes
Dec 3, 2025
mcdurdin
deleted the
maint/common/15130-use-builder_launch-for-child-builds
branch
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.171-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
--debugand--releaseflags removed (along with--no-deps). This cleans up poor child script calls which should make builds more robust and consistent and potentially faster too.Fixes: #15130
Test-bot: skip