feat(android): Add Grabbable Bar and settings status for keyboard resizing

[MattGyverLee]

As dicussed on slack, I've ported the "grabbable" bar for keyboard resizing from the App builders. The bar is animated when you touch it. I've tested this in a build of the Keyman App. Resizing seems to work well after build, even though the app keeps giving (hopefully) unrelated errors about a null language. Oh, I set the % text on the resize screen to grey after I took the screenshots and merged the text boxes at the top.

User Testing

Setup - Install the PR build of Keyman for Android on a device/emulator

• TEST_MENU - Verifies functionality of the "Adjust Keyboard Height" menu

1. With the device in portrait orientation, launch Keman for Android and dismiss the "Get Started" menu
2. Observe the height of the OSK
3. From Keyman Settings --> Adjust keyboard height
4. Verify "Adjust keyboard height" menu
   a. Drag the bar to adjust the height, rotate the phone and adjust again
   b. Try the reset menu, then adjust to a non 100% height.
   b. Verify the corresponding portrait/landscape % updates
5. Exit the dialog and verify that the same percentages are shown in Settings.
   Note: The settings should "stick" if you tap the back button on the top bar, the phone back button, or switch apps.
6. Exit the settings and verify the in-app OSK matches the last keyboard heights (vertical and landscape)
   Note: The top of the keyboard image in the dialog should line up with the top of the keyboard. Both the draggable bar and the suggestion bar will show above that line.

[keymanapp-test-bot]

User Test Results

Test specification and instructions

• ✅ TEST_MENU (PASSED) (notes)

[keyman-server]

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

[MattGyverLee]

I knew it was coming, but I was quite surprised when KMManager had moved on master when I went to rebase!

[MattGyverLee]

@mcdurdin Do we need to port this over to the FV app or KmSample2?

[darcywong00]

@mcdurdin Do we need to port this over to the FV app or KmSample2?

I don't think so. Those apps don't have a menu to adjust the keyboard height.

[darcywong00]

ERROR: user tests have not yet been defined

I'll update the PR description with a template for user testing. @MattGyverLee - you can adjust the test steps

[mcdurdin]

Thank you for your contribution.

I'd like this to be refactored to be much simpler and not make changes to KMManager. As it stands, it's adding a large amount of API surface to Keyman Engine for very little benefit. The five KMManager functions added are all trivial utility functions, which will increase the future maintenance burden for Keyman Engine for Android.

As a basic principle, API surfaces should be kept as simple and clean as possible, and utility functions should not be added to general APIs. Part of the problem here is that years ago we were not particularly careful with a lot of the API surfaces across Keyman as a whole. But that has caused ongoing problems with maintenance of Keyman Engine for Android. So where we are now, we don't want to perpetuate the problem further.

• In my opinion, the function calculateKeyboardHeightFromTouch is just unnecessary. It's a totally trivial calculation and is called just once; it takes 5 lines out of that single use and turns it into nearly 150 lines of very verbose documentation and code.

• The function createKeyboardHeightString does not belong in KMManager -- this is an app presentation detail. Furthermore, the string itself needs to be localizable as a whole with parameterization. I am also uncomfortable with the 'live' variant of the function -- that parameterization should be in a higher level function that calls createKeyboardHeightString.

• Similarly getKeyboardHeightPercentage is a trivial calculation. It could be a utility function but it should not be in Keyman Engine.

[MattGyverLee]

Thanks. The refactoring should be easy, those functions got moved to KMManager on one of the last commits.

[MattGyverLee]

Ok, I just cut out a LOT of spaghetti code. Ready for another look.

[mcdurdin]

This looks great, thank you for your contribution -- nice improvement which also retires a bit of tech debt.

[mcdurdin]

Note: this should probably be merged as a squash merge as it is an external contribution.

[MattGyverLee]

Thanks! Back to you.

[mcdurdin]

Thanks! Back to you.

you'll need to fix the call to calculateKeyboardHeightFromTouch as well

[MattGyverLee]

Better? I learn a lot about improving code from your reviews.

[mcdurdin]

LGTM pending build

[mcdurdin]

I learn a lot about improving code from your reviews.

Awesome! Glad you are finding my feedback constructive 😁

Sadly, build failed:

16:52:42       /var/lib/teamcity-agent/work/30ffb35c1b6c4089/keyman/android/KMAPro/kMAPro/src/main/res/values-in-rID/strings.xml:116: Error: "drag_the_keyboard" is translated here but not found in default locale [ExtraTranslation]
16:52:42         <string name="drag_the_keyboard" comment="First line of adjusting keyboard height">Drag the keyboard to resize the height</string>
16:52:42                 ~~~~~~~~~~~~~~~~~~~~~~~~

I am out of time to do any more review; I will be unavailable until January as I am travelling back to Australia tomorrow, @darcywong00 will take over code review from here.

[MattGyverLee]

I had actually intended to merge those strings into one text box. Merged now with language-adaptive punctuation. @darcywong00 I hope this has also resolved the build error.

[darcywong00]

@Meng-Heng - I'm not sure why the build artifacts weren't attached.
Here's the link to Keyman for Android

[Meng-Heng]

I'll test this in the afternoon (my time).

[mcdurdin]

I'm not sure why the build artifacts weren't attached.

Network glitch potentially, or status.keyman.com hiccups. We'll monitor in case this is an ongoing issue.

[Meng-Heng]

Test Specs

1. Android Studio, Pixel 8a API34

Test Results

• TEST_MENU (PASSED):

1. Launch Keyman 19.0.169-alpha-test-15267
2. Dismiss the Startup dialog, Go to Settings
3. Verified: Adjust keyboard height for Portrait & Landscape mode
   • The height percentage increases and decreases according to the resizing direction of the keyboard height
   • The height stays when rotating back and forth between landscape and portrait
   • Reset back to defaults work as expected.
4. Verified: Settings screen
   • The percentages are the same
   • The settings stay after back-tapping, exiting, switching, closing the app.
5. Verified: OSK
   • The OSK heights matches the set heights and the keyboard image in the dialog
   • Typing and using the predictive text work as expected.

[keyman-server]

Changes in this pull request will be available for download in Keyman version 19.0.173-alpha