Skip to content

docs(web): add links to next/previous page to web guide#15311

Merged
ermshiperete merged 4 commits intomasterfrom
docs/web/guide
Dec 8, 2025
Merged

docs(web): add links to next/previous page to web guide#15311
ermshiperete merged 4 commits intomasterfrom
docs/web/guide

Conversation

@ermshiperete
Copy link
Copy Markdown
Contributor

@ermshiperete ermshiperete commented Dec 5, 2025

Fixes: keymanapp/help.keyman.com#1781
Build-bot: skip
Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S17 milestone Dec 5, 2025
@keyman-server keyman-server modified the milestones: A19S17, A19S18 Dec 6, 2025
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation needs so much work ... Changes LGTM, feel free to ignore my documentation suggestions because they only scratch the surface.


- The `<script>` inclusion `<script src='https://s.keyman.com/kmw/engine/17.0.330/keymanweb.js'></script>` loads the Keyman Engine for Web script for the page.
- The `<script>` inclusion `<script
src='https://s.keyman.com/kmw/engine/17.0.330/keymanweb.js'></script>` loads the Keyman Engine
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update to the latest release version since you are working on the page?

Co-authored-by: Marc Durdin <marc@durdin.net>
@github-actions github-actions bot added docs and removed docs labels Dec 8, 2025
Addresses a code review comment.
This removes the specific version from the control-by-control example
and thus makes it similar to the other examples where we use a relative
path. `get-started.md` and the *.html files will still show how this can
be done with a specific version.

Build-bot: skip
Test-bot: skip
@github-actions github-actions bot added docs and removed docs labels Dec 8, 2025
@ermshiperete ermshiperete merged commit 026096f into master Dec 8, 2025
6 checks passed
@ermshiperete ermshiperete deleted the docs/web/guide branch December 8, 2025 09:40
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Dec 8, 2025
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.172-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

feat: add buttons for previous/next page to the KeymanWeb guide

3 participants