fix(mac): ensure retry for mac disk detach actually repeats#15330
Merged
fix(mac): ensure retry for mac disk detach actually repeats#15330
Conversation
Increment needed a guard in order to not abort the script. I have tested locally (stubbing out hdiutil and replacing with false!) -- so I am more confident this time. Test-bot: skip Build-bot: skip Follows: #15176
User Test ResultsTest specification and instructions User tests are not required |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.180-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increment needed a guard in order to not abort the script. I have tested locally (stubbing out hdiutil and replacing with false!) -- so I am more confident this time.
Test-bot: skip
Build-bot: skip
Follows: #15176