feat(web): add CookieSerializer.loadAllMatching function 🍪 🎼#15429
Merged
Conversation
- rename tests from `cookies.tests.ts` → `cookieSerializer.tests.ts` - add test for new function Part-of: #13426 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
Bot
changed the title
CookieSerializer.loadAllMatching functionCookieSerializer.loadAllMatching function 🎼
ermshiperete
changed the title
CookieSerializer.loadAllMatching function 🎼CookieSerializer.loadAllMatching function 🍪 🎼
mcdurdin
approved these changes
Jan 14, 2026
| this.saveCookie(this.name, cookie, encoder || ((val: DecodedCookieFieldValue) => val as string)); | ||
| } | ||
|
|
||
| public static loadAllMatching<Type extends Record<keyof Type, DecodedCookieFieldValue>>(pattern: RegExp, decoder?: FilteredRecordDecoder): { name: string, value: Type }[] { |
Member
There was a problem hiding this comment.
Please include a javadoc comment when adding new publics
| }); | ||
|
|
||
| afterEach(() => { | ||
| document.cookie = `${COOKIE_ID}=; ${RESET}`; |
Member
There was a problem hiding this comment.
Is this needed as well as the same thing in beforeEach()? Seems redundant
Contributor
Author
There was a problem hiding this comment.
Since it seems cleaner to remove the cookie the test added after running the test so that other tests start with a clean slate, I left afterEach and removed beforeEach.
The only downside is that if for whatever reason the cookie didn't got purged the test will now fail because we don't purge it before the test, but I think we can live with that. Re-running it would then cause it to pass.
Test-bot: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cookies.tests.ts→cookieSerializer.tests.tsPart-of: #13426
Test-bot: skip