fix(windows): export sym store path so symbols are published #15493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #14837 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Jan 26, 2026
rc-swag
approved these changes
Jan 27, 2026
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.194-alpha |
This was referenced Jan 28, 2026
mcdurdin
added a commit
that referenced
this pull request
Jan 28, 2026
There were two issues arising from #15493 - first, `$KEYMAN_SYMSTOREPATH` was set too late, after the build, and second, symsrv renames `000admin` to `000Admin` but we need to keep it lowercase for our deployment server, so rename it back just in time before uploading. As tidy-up, given that the folder name `000admin` is static and never changes, removed the parameter and hard-coded it instead. * export `$KEYMAN_SYMSTOREPATH` before build * define `000admin` folder explicitly and deprecate --symbols-subdir parameter * rename `000Admin` to `000admin` before upload Fixes: #14837 Follows: #15493 Test-bot: skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KEYMAN_SYMSTOREPATHis used inwrap-symstore, and if missing, no symbols are written to the local symbol store for later publication to downloads.keyman.com.Fixes: #14837
Test-bot: skip